-
-
Notifications
You must be signed in to change notification settings - Fork 354
feat(fzf_lua): add custom ActionPreviewer for improved action preview #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nothankyouzzz
wants to merge
5
commits into
olimorris:main
Choose a base branch
from
nothankyouzzz:feat/fzf-lua-chat-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
120efc1
feat(fzf_lua): add custom ActionPreviewer for improved action preview
nothankyouzzz a4dfe41
feat(fzf_lua): Use window title for picker prompt
nothankyouzzz e451125
feat(types): add shared ActionItem types and annotate providers
nothankyouzzz 19d77b2
feat(fzf_lua): render prompt via winopts.title; keep custom previewer
nothankyouzzz 11251c7
fix(slash_commands/fzf_lua): set title via winopts.title (not prompt)
nothankyouzzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add annotations and types to the function names like I do throughout CodeCompanion? Otherwise this looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a sec, I'm adding tests. I'll handle it once that's done. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I've obviously confused things. I meant provide type annotations like
stringornumber. Not expecting you to come up with an fzf specific class and typesUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not entirely sure which parts you’d like me to annotate.
If you’re referring to
oandoptsin theActionPreviewerconstructor, their content and usage are internal tofzf-lua. Specifically,ocorresponds to thepreviewertable infzf_exec, andoptsis fzf’s internal config table.Since these annotations were generated by GPT, it might be better to either remove them or replace them with a link to the relevant file in the
fzf-luarepo.The
ActionPreviewerclass in the diff is a chat previewer that customizes the behavior offzf_exec, similar to theaction_previewerinactions/telescope.lua. Since I haven’t modified any internal API interfaces (new,picker, orselect), and as you mentioned there’s no need to cover fzf-specific classes, I believe the existing annotations should be sufficient.If any part of the PR remains unclear, I’d be happy to provide a more detailed explanation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve force-pushed the modified annotations — hopefully this clears up any doubts.