Skip to content

feat(ui): revise confirmation dialog to be non-blocking#2849

Closed
cenk1cenk2 wants to merge 31 commits into
olimorris:mainfrom
cenk1cenk2:patch-5
Closed

feat(ui): revise confirmation dialog to be non-blocking#2849
cenk1cenk2 wants to merge 31 commits into
olimorris:mainfrom
cenk1cenk2:patch-5

Conversation

@cenk1cenk2
Copy link
Copy Markdown
Contributor

@cenk1cenk2 cenk1cenk2 commented Mar 4, 2026

Description

  • Changes the confirmation dialog to be async with a floating window instead of the confirm UI, so whenever tool requests come in through the ACP, it would not block the UI. Currently, whenever there are multiple tool calls spawned, and there is no orchestration of tasks with ACP adapters, the UI hangs, so you do not actually know what you are agreeing to.
  • The spawned confirmation dialog will have more information about the arguments that the tool is getting called. Sometimes, utilizing a tool from the MCP adapter attached, you might want to investigate the call in detail just to make sure everything is as expected.

AI Usage

  • Claude Opus 4.6

It is used to design the floating window interface. It is also used to ensure that there are no holes in the async mechanism, where blocking might be needed and testing.

Related Issue(s)

Screenshots

image

Checklist

  • I've read the contributing guidelines and have adhered to them in this PR
  • I confirm that this PR has been majority created by me, and not AI (unless stated in the "AI Usage" section above)
  • I've run make all to ensure docs are generated, tests pass and StyLua has formatted the code
  • (optional) I've added test coverage for this fix/feature
  • (optional) I've updated the README and/or relevant docs pages

@cenk1cenk2 cenk1cenk2 changed the title feat(ui): revise confirmation dialog to be non-blocking with more inf… feat(ui): revise confirmation dialog to be non-blocking Mar 4, 2026
@cenk1cenk2 cenk1cenk2 marked this pull request as ready for review March 4, 2026 15:02
@cenk1cenk2 cenk1cenk2 force-pushed the patch-5 branch 2 times, most recently from 65c7df2 to 6431b8f Compare March 4, 2026 15:35
fix: update

fix: .

fix: .
@olimorris
Copy link
Copy Markdown
Owner

Hey @cenk1cenk2

Appreciate you taking the time to put together a PR. I recognise that vim.fn.confirm isn't ideal for a lot of users but this represents a huge change that I'll have to think about. Right now, I broadly agree with this but will give it a couple of weeks to think it through whilst I work on the roadmap.

@cenk1cenk2
Copy link
Copy Markdown
Contributor Author

Thank you for your time yet again to consider it.

@olimorris
Copy link
Copy Markdown
Owner

FYI, #2917 will address this.

@olimorris olimorris closed this Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants