Another polygon improvement from Issue #1907#2034
Open
WileECoder wants to merge 11 commits into
Open
Conversation
…to polygon-mask
…to polygon-mask
…to polygon-mask
Collaborator
|
Olive is about to undergo some largish code refactoring and I wanted to check on the status of old PRs before we do that. Do you plan to update/continue with the PR? Thanks |
Author
|
While I still think this is a useful feature, chances are that a refactoring will generate too many conflicts. Fell free to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1907 and improves the behaviour of Bezier polygon (and the Mask node).
Both issues from @itsmattkc and @unfa are addressed; in particular:
In order to grab a control point, ALT modifier can be used. If control point is isolated, ALT modifier is not needed.
I have made a video to show how this works.
NOTE: This PR duplicates the one from @p9malino26 (#2030). I did not realize he was working on the same issue.
Feel free to use the best implementation or take something good from both ...