improve latency by running "SELECT" only if the db is different#981
Merged
improve latency by running "SELECT" only if the db is different#981
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #981 +/- ##
==========================================
- Coverage 82.08% 82.06% -0.03%
==========================================
Files 18 18
Lines 2663 2732 +69
==========================================
+ Hits 2186 2242 +56
- Misses 390 399 +9
- Partials 87 91 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 13691305086Details
💛 - Coveralls |
179250d to
75fcd0b
Compare
7e307f3 to
eed4760
Compare
eed4760 to
8f7917e
Compare
35ad04f to
15c18f7
Compare
Owner
Author
|
Some rudimentary benchmarking with about 10 keys showed a reduction in latency for a full scrape from about 5s to 3s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #980