Skip to content

Comments

improve latency by running "SELECT" only if the db is different#981

Merged
oliver006 merged 5 commits intomasterfrom
oh_checkkeys_scrape_latency
Mar 6, 2025
Merged

improve latency by running "SELECT" only if the db is different#981
oliver006 merged 5 commits intomasterfrom
oh_checkkeys_scrape_latency

Conversation

@oliver006
Copy link
Owner

@oliver006 oliver006 commented Mar 1, 2025

related to #980

@codecov
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 84.09091% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.06%. Comparing base (f99f69a) to head (15c18f7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
exporter/keys.go 83.13% 10 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
- Coverage   82.08%   82.06%   -0.03%     
==========================================
  Files          18       18              
  Lines        2663     2732      +69     
==========================================
+ Hits         2186     2242      +56     
- Misses        390      399       +9     
- Partials       87       91       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Mar 1, 2025

Pull Request Test Coverage Report for Build 13691305086

Details

  • 78 of 88 (88.64%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 85.443%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exporter/keys.go 73 83 87.95%
Totals Coverage Status
Change from base Build 13078474001: 0.04%
Covered Lines: 2342
Relevant Lines: 2741

💛 - Coveralls

@oliver006 oliver006 force-pushed the oh_checkkeys_scrape_latency branch 2 times, most recently from 179250d to 75fcd0b Compare March 5, 2025 04:29
@oliver006 oliver006 force-pushed the oh_checkkeys_scrape_latency branch 4 times, most recently from 7e307f3 to eed4760 Compare March 5, 2025 05:58
@oliver006 oliver006 force-pushed the oh_checkkeys_scrape_latency branch from eed4760 to 8f7917e Compare March 5, 2025 06:02
@oliver006 oliver006 force-pushed the oh_checkkeys_scrape_latency branch from 35ad04f to 15c18f7 Compare March 6, 2025 04:37
@oliver006 oliver006 merged commit 3eb0d6e into master Mar 6, 2025
9 checks passed
@oliver006 oliver006 deleted the oh_checkkeys_scrape_latency branch March 6, 2025 06:32
@oliver006
Copy link
Owner Author

Some rudimentary benchmarking with about 10 keys showed a reduction in latency for a full scrape from about 5s to 3s.
There's still room for improvement but that's a lot more work and I don't have bandwidth for that right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants