Don't arbitrarily delete extra files in project folder, allow images in project folder #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
obw
reviewed
Jul 22, 2020
| if f[-4:] in [".xml", "opml"]: | ||
| with open(os.path.join(dirpath, f), "rb") as fo: | ||
| files[os.path.join(p, f)] = fo.read() | ||
| elif f[-4:] in [".png", "jpeg",".jpg","bmp","tiff",".gif",".pdf"]: |
Contributor
There was a problem hiding this comment.
This should by configurable, I use often SVG images.
Also HTML Files often with research information or other filetypes. (bst -> bibtex and so on)
In the moment I store my Images in folder on the same level as the project-file (I do not us the zip/one-file mode!)... So I don't have this Problem.
Collaborator
|
I think that's something to look into when making changes improving the storage system overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the program deletes any files that it doesn't recognize in your project folder. Perhaps useful for deleting "orphan" files, but if you store things like custom pandoc YAML files and various peripheral files in that folder, then it seems rather destructive to always be arbitrarily deleting files like these.