Close file handles with context managers - #541
Open
ThVerg wants to merge 1 commit into
Open
Conversation
modelsim and questaformal opened their generated tcl/Makefile outputs without closing them (or closed them in a non-exception-safe way), which shows up as ResourceWarnings under pytest. reporting and tools/edatool leaked read handles the same way. Convert all of them to with-statements. No functional change; the test suite passes with -W error::ResourceWarning.
ThVerg
force-pushed
the
fix/unclosed-file-handles
branch
from
July 2, 2026 12:21
00dcddc to
c5ecd00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modelsim and questaformal backends open their generated
.tclandMakefileoutputs without closing them (_write_build_rtl_tcl_filenever closes; the others close but not exception-safely), which shows up asResourceWarnings when running the test suite.reporting.pyandtools/edatool.pyleak read handles the same way (open(...).read()).This converts all of them to
withcontext managers. The diff in modelsim/questaformal looks large but is almost entirely re-indentation of the method bodies under thewithblock — no functional change.Verified: full test suite passes with
-W error::ResourceWarning(204 passed), and the golden-file tests confirm generated output is unchanged. Formatted with black 22.3.0.