-
Notifications
You must be signed in to change notification settings - Fork 266
Monetdb #183
base: master
Are you sure you want to change the base?
Monetdb #183
Conversation
KimMoriarty
commented
Dec 15, 2017
- Slightly modified and added ddls for monetdb for Wikipedia benchmark.
- Modified Wikipedia benchmark to bypass an issue.
- Config file for each benchmark: tpcc, tpch, Wikipedia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address my comments.
config/sample_tpcc_config.xml
Outdated
<driver>com.mysql.jdbc.Driver</driver> | ||
<DBUrl>jdbc:mysql://localhost:3306/tpcc</DBUrl> | ||
<username>root</username> | ||
<dbtype>MONETDB</dbtype> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change the default sample config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create new config xml files named tpcc_config_monetdb
, tpch_config_monetdb
, wikipedia_config_monetdb
.
} | ||
batchSize++; | ||
} // FOR (revision) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed here? Is it just formatting? What parts are MonetDB specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tried to remove the loop for num_revised
, which effectively the same as setting num_revised=1
in all cases. We do this because we found otherwise duplicate tuples will be inserted and causing a primary key violation error. We suspect Monetdb may not have a good support for transaction, but we are not sure...