tests refactored 2

Author: olyapka84

tests/test_tasks_crud.py

@@ -1,164 +1,112 @@
 import pytest
-from django.contrib.auth import get_user_model
 from django.test import Client
 from django.urls import reverse
-from task_manager.tasks.models import Task
+from django.contrib.auth import get_user_model
+
 from task_manager.statuses.models import Status
+from task_manager.tasks.models import Task
 
 User = get_user_model()
-
-
-@pytest.fixture
-def status_new(db):
-    return Status.objects.create(name="новый")
+pytestmark = pytest.mark.django_db
 
 
 @pytest.fixture
 def users(db):
-    password = "P@ssw0rd12345"
-    u1 = User.objects.create_user(
-        username="alice", password=password, first_name="Alice", last_name="A"
-    )
-    u2 = User.objects.create_user(
-        username="bob", password=password, first_name="Bob", last_name="B"
-    )
-    return {"alice": u1, "bob": u2, "password": password}
+    pwd = "p12345678"
+    u1 = User.objects.create_user(username="user1", password=pwd)
+    u2 = User.objects.create_user(username="user2", password=pwd)
+    return {"u1": u1, "u2": u2, "pwd": pwd}
 
 
 @pytest.fixture
 def auth_client(users):
     c = Client()
-    c.login(username="alice", password=users["password"])
+    c.login(username="user1", password=users["pwd"])
     return c
 
 
-@pytest.mark.django_db
-def test_users_list_is_public(client, users):
-    resp = client.get(reverse("list", current_app="users"))
-    assert resp.status_code == 200
-    html = resp.content.decode()
-    assert "alice" in html
-    assert "bob" in html
-
-
-@pytest.mark.django_db
-def test_registration_get(client):
-    r = client.get(reverse("create", current_app="users"))
-    assert r.status_code == 200
-    html = r.content.decode()
-    assert 'name="username"' in html
-    assert 'name="password1"' in html
-    assert 'name="password2"' in html
-
-
-@pytest.mark.django_db
-def test_registration_post_creates_user(client):
-    data = {
-        "username": "charlie",
-        "first_name": "Charlie",
-        "last_name": "C",
-        "password1": "XyZ12345!xyZ",
-        "password2": "XyZ12345!xyZ",
-    }
-    r = client.post(reverse("create", current_app="users"), data=data)
-    assert r.status_code in (302, 301)
-    assert User.objects.filter(username="charlie").exists()
+@pytest.fixture
+def status_new(db):
+    return Status.objects.create(name="новый")
 
 
-@pytest.mark.django_db
-def test_update_requires_auth_redirects(client, users):
-    url = reverse("update", args=[users["alice"].pk], current_app="users")
-    r = client.get(url)
+def test_login_required(client):
+    r = client.get(reverse("tasks:index"))
     assert r.status_code in (302, 301)
-    assert reverse("login") in r.url
-    assert f"next={url}" in r.url
-
-
-@pytest.mark.django_db
-def test_user_can_update_self(auth_client, users):
-    url = reverse("update", args=[users["alice"].pk], current_app="users")
-    r_get = auth_client.get(url)
-    assert r_get.status_code == 200
-
-    r_post = auth_client.post(
-        url,
-        data={"username": "alice_new", "first_name": "Al", "last_name": "A"},
-    )
-    assert r_post.status_code in (302, 301)
-
-    users["alice"].refresh_from_db()
-    assert users["alice"].username == "alice_new"
-    assert users["alice"].first_name == "Al"
-
 
-@pytest.mark.django_db
-def test_user_cannot_update_other(auth_client, users):
-    url = reverse("update", args=[users["bob"].pk], current_app="users")
-    r = auth_client.post(url, data={"username": "bob_hacked"})
-    assert r.status_code in (302, 403, 404)
-    users["bob"].refresh_from_db()
-    assert users["bob"].username == "bob"
 
-
-@pytest.mark.django_db
-def test_delete_requires_auth_redirects(client, users):
-    url = reverse("delete", args=[users["alice"].pk], current_app="users")
-    r = client.get(url)
-    assert r.status_code in (302, 301)
-    assert reverse("login") in r.url
+def test_list(auth_client, users, status_new):
+    Task.objects.create(name="Тестовая задача", description="Описание",
+                        status=status_new, author=users["u1"])
+    Task.objects.create(name="Вторая", description="Ещё одна",
+                        status=status_new, author=users["u1"])
+    r = auth_client.get(reverse("tasks:index"))
+    assert r.status_code == 200
+    html = r.content.decode()
+    assert "Тестовая задача" in html
+    assert "Вторая" in html
+
+
+def test_create(auth_client, users, status_new):
+    resp = auth_client.post(reverse("tasks:create"), data={
+        "name": "Новая задача",
+        "description": "Что-то сделать",
+        "status": status_new.pk,
+        "executor": users["u2"].pk,
+    })
+    assert resp.status_code in (302, 301)
+    assert Task.objects.filter(name="Новая задача",
+                               status=status_new,
+                               author=users["u1"]).exists()
+
+
+def test_update(auth_client, users, status_new):
+    t = Task.objects.create(name="Черновик", description="Описание",
+                            status=status_new, author=users["u1"])
+    resp = auth_client.post(reverse("tasks:update", args=[t.pk]), data={
+        "name": "Изменено",
+        "description": "Новое описание",
+        "status": status_new.pk,
+        "executor": users["u2"].pk,
+    })
+    assert resp.status_code in (302, 301)
+    t.refresh_from_db()
+    assert t.name == "Изменено"
+    assert t.description == "Новое описание"
+    assert t.executor == users["u2"]
+
+
+def test_view(auth_client, users, status_new):
+    t = Task.objects.create(name="Посмотреть", description="Детали",
+                            status=status_new, author=users["u1"])
+    r = auth_client.get(reverse("tasks:detail", args=[t.pk]))
+    assert r.status_code == 200
+    html = r.content.decode()
+    assert "Посмотреть" in html
+    assert "Детали" in html
 
 
-@pytest.mark.django_db
-def test_user_can_delete_self(users):
-    c = Client()
-    c.login(username="bob", password=users["password"])
-    url = reverse("delete", args=[users["bob"].pk], current_app="users")
-    r_get = c.get(url)
+def test_delete(auth_client, users, status_new):
+    t = Task.objects.create(name="Удалить", description="Ненужная",
+                            status=status_new, author=users["u1"])
+    r_get = auth_client.get(reverse("tasks:delete", args=[t.pk]))
     assert r_get.status_code == 200
-    r_post = c.post(url)
+    r_post = auth_client.post(reverse("tasks:delete", args=[t.pk]))
     assert r_post.status_code in (302, 301)
-    assert not User.objects.filter(pk=users["bob"].pk).exists()
-
-
-@pytest.mark.django_db
-def test_user_cannot_delete_other(auth_client, users):
-    url = reverse("delete", args=[users["bob"].pk], current_app="users")
-    r = auth_client.post(url)
-    assert r.status_code in (302, 403, 404)
-    assert User.objects.filter(pk=users["bob"].pk).exists()
+    assert not Task.objects.filter(pk=t.pk).exists()
 
 
-@pytest.mark.django_db
 def test_only_author_can_delete(auth_client, users, status_new):
     t = Task.objects.create(
-        name="Чужая задача",
-        description="...",
-        status=status_new,
-        author=users["bob"],
+        name="Чужая задача", description="...",
+        status=status_new, author=users["u2"]
     )
     r = auth_client.post(reverse("tasks:delete", args=[t.pk]))
     assert r.status_code in (302, 301)
     assert Task.objects.filter(pk=t.pk).exists()
 
     c = Client()
-    c.login(username="bob", password=users["password"])
+    c.login(username="user2", password=users["pwd"])
     r2 = c.post(reverse("tasks:delete", args=[t.pk]))
     assert r2.status_code in (302, 301)
     assert not Task.objects.filter(pk=t.pk).exists()
-
-
-@pytest.mark.django_db
-def test_user_with_tasks_cannot_be_deleted(users, status_new):
-    Task.objects.create(
-        name="Тестовая",
-        description="Проверка",
-        status=status_new,
-        author=users["bob"],
-    )
-
-    c = Client()
-    c.login(username="bob", password=users["password"])
-    url = reverse("delete", args=[users["bob"].pk], current_app="users")
-    r = c.post(url)
-    assert r.status_code in (302, 301)
-    assert User.objects.filter(pk=users["bob"].pk).exists()