feat!: Playwright locator API for full selector support #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8c1d91 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
added 14 commits
January 28, 2026 16:36
BREAKING CHANGE: Shadow DOM piercing syntax changes from `>>>` to `>>` (legacy `>>>` still works) - Use page.locator() instead of custom querySelector for element capture - Support all Playwright selector formats: CSS, XPath, text, role - Shadow DOM: use `>>` for chaining (Playwright standard) - Backward compatible: `>>>` auto-converts to `>>` - Add normalizeSelector() for syntax conversion - Update browserFunctions and editor to support both syntaxes - Add elementFinder tests - Document new selector formats in screenshot-reference.md
- Add sync.test.ts with 11 tests for sync() function - Fix gap: throw error when explicit config path doesn't exist - Previously silently returned empty result for missing config - Tests cover: empty config, filter handling, options validation
- Add 6 tests for syncHandler in tools.test.ts - Tests cover: error handling, empty config, filter passthrough, result structure, session key from env, explicit session key priority
- Test that empty jobs array returns empty results without launching browsers - Note: Full error handling tests for batch failures would require browser mocking which is complex
- Add tests for whitespace trimming, double space collapsing - Test empty string, single > (CSS child combinator), mixed >>> and >> - Document that findElement() is tested via CLI integration tests
- Add test that verifies form is filled correctly by actions - Test captures form after type, select_option, and evaluate actions - Compares result to baseline (runs on CI only for font consistency)
- Add screenshotPath tests: very long names, unicode, empty, special chars - Add schema tests: URLs with special chars, IDN domains, fragments, ports - Add performance test: config with 100 screenshots
- Test empty session file returns null - Test truncated/corrupted file returns null - Test random binary garbage returns null - All corrupted files handled gracefully without throwing
- Test class names with special characters (: and [) - Test SVG elements inside shadow DOM - Test deeply nested shadow DOM (host >> host >> element)
- Changed from Promise.all to Promise.allSettled in captureParallel - If one worker's browser fails, other workers' results are still collected - Prevents losing all results when a single batch encounters an error
- Update selector schema description to mention Playwright selector formats - Regenerate docs from updated schema - Increase test timeout for 'fails gracefully with invalid selector' from 60s to 90s (test takes ~40s locally, CI is slower)
Add NOSONAR comments to test code that uses: - Math.random() for generating random test data (not crypto) - /tmp/test as mock output directory (not production code)
omachala
force-pushed
the
feat/playwright-locators
branch
from
99560e0 to
d8c1d91
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switch from custom
querySelectorimplementation to Playwright's nativepage.locator()API, enabling full Playwright selector format support.Breaking Change
>>(Playwright standard)>>>syntax still works (auto-converted to>>)New Selector Formats Supported
Now supports all Playwright selector types:
.button,#headermy-component >> .innerxpath=//button[@id="submit"]text=Submitrole=button[name="OK"].modal >> role=button[name="Close"]Changes
elementFinder.ts: Usepage.locator()instead of customevaluateHandlebrowserFunctions.ts: Support both>>>and>>syntaxeditor/selector.ts: Support both syntaxes in visual pickernormalizeSelector()function with testsTest plan