Skip to content

Let users review and suppress recurring crash types - #9448

Open
ferlemes wants to merge 1 commit into
omacom:quattrofrom
ferlemes:feature/crash-review-actions
Open

Let users review and suppress recurring crash types#9448
ferlemes wants to merge 1 commit into
omacom:quattrofrom
ferlemes:feature/crash-review-actions

Conversation

@ferlemes

Copy link
Copy Markdown

Motivation

Crash notifications currently hand a crash directly to the default AI agent when clicked. That is useful for a new failure, but it becomes noisy when the same known crash keeps recurring and the user has already decided not to investigate or fix it.

The case that motivated this change was a crash repeatedly triggered while Claude was performing an operation. It was not a crash I planned to address, but each occurrence still offered the same direct diagnosis path. Muting the whole program would be too broad because a different crash from that executable could still be actionable.

What changed

  • Open a local crash review before launching the AI diagnosis.
  • Retain a private summary and recurrence count for each crash type.
  • Define a crash type from the executable, signal, and command line, hashed as a SHA-256 signature.
  • Let users dismiss one occurrence, snooze a crash type, ignore that exact crash type permanently, or mute all crashes from the program.
  • Keep counting ignored recurrences without showing another notification.
  • Deduplicate notifications by crash signature rather than only by program name.
  • Document the review and ignore flows and cover them in the crash capture tests.

This keeps unrelated failures visible: ignoring one known probe does not suppress every crash from the same executable.

Testing

  • bash test/shell.d/crash-capture-test.sh passes.
  • Built and installed the development package locally, generated a real SIGSEGV core dump from /usr/bin/sleep, and verified that the notification opened the new review flow.
  • ./test/all was also run. The crash coverage passes; the suite reports four failures outside the touched area: launch-about-test.sh, network-qr-test.sh, plugin-add-test.sh (GPG state is read-only in the sandbox), and snapper-test.sh (the sibling omarchy-iso checkout is unavailable).

@ferlemes
ferlemes force-pushed the feature/crash-review-actions branch from 2645b03 to 73c2a3d Compare August 31, 2026 19:57
@lemes-eulen

Copy link
Copy Markdown

Crash review screen:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants