Let users review and suppress recurring crash types - #9448
Open
ferlemes wants to merge 1 commit into
Open
Conversation
ferlemes
force-pushed
the
feature/crash-review-actions
branch
from
August 31, 2026 19:57
2645b03 to
73c2a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Crash notifications currently hand a crash directly to the default AI agent when clicked. That is useful for a new failure, but it becomes noisy when the same known crash keeps recurring and the user has already decided not to investigate or fix it.
The case that motivated this change was a crash repeatedly triggered while Claude was performing an operation. It was not a crash I planned to address, but each occurrence still offered the same direct diagnosis path. Muting the whole program would be too broad because a different crash from that executable could still be actionable.
What changed
This keeps unrelated failures visible: ignoring one known probe does not suppress every crash from the same executable.
Testing
bash test/shell.d/crash-capture-test.shpasses.SIGSEGVcore dump from/usr/bin/sleep, and verified that the notification opened the new review flow../test/allwas also run. The crash coverage passes; the suite reports four failures outside the touched area:launch-about-test.sh,network-qr-test.sh,plugin-add-test.sh(GPG state is read-only in the sandbox), andsnapper-test.sh(the siblingomarchy-isocheckout is unavailable).