[fix] Keep Launch visible with a compact action area - #187
Open
Fail-Safe wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The start menu caps its content height at 832 points, so permission prompts and longer settings can push Launch below the visible area. Size the window from its laid-out content up to the display's available height, and keep Launch and the secondary actions outside the scrolling settings area.
Launch remains full-width. Center Reset beneath it, with the existing linked attribution aligned to Launch's right edge on the same row. This reduces the fixed action area's height while keeping Reset below Launch. Settings retain their scroll position when the window is sized, and accessibility reading order follows settings then actions.
Example:

This includes the button-order commit from #186. If #186 merges first, that portion will drop out of this diff. The Return-key launch action, reset confirmation, permission behavior, and VM settings are unchanged.
Validation:
make testpassed under the installed Xcode toolchain: 243 native tests, 103 guest tests, and shell/storage contracts. The optional virtio-pinch guest ABI test was skipped because its test binary was not configured.git diff --checkpassed.This PR has not been installed into the daily-use app bundle.