Skip to content

Conversation

@dnrahamim
Copy link

@dnrahamim dnrahamim commented Mar 22, 2024

This PR ensures that the Dockerfile can be built successfully. I made these changes because I was not able to build the base Image/Container upon cloning this repo.

Change Summary:

  • Uses linux/amd64 emulation by default
  • Uses ApacheDS version 2.0.0.AM27 (partly because version 2.0.0.AM26 couldn't be found at the previously hardcoded URL)
  • Updates environment variables to use 2.0.0.AM28-SNAPSHOT (which is installed by 2.0.0.AM27)
  • Fixes file paths broken by version upgrade
  • Splits up a few build steps that have trouble completing on their own
  • Installs python-ldap using pip (because apt-get wouldn't work). Installs necessary dependencies

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dnrahamim. Recent fixes have M26 working again. Can you give us background on why the changes here are needed?

docker run --name ldap -d -p 389:10389 openmicroscopy/apacheds
Create and run a container using the image that was built in the previous steps:

docker run --name ldap --platform linux/amd64 -dit -p 389:10389 openmicroscopy/apacheds:2.0.0.AM27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I see how you are referring here to the above commands but we also want a suggestion on how to run publicly. Maybe duplicate if you think it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants