Chunk API: Add new API and functionality for reading and writing chunks#3794
Open
dgault wants to merge 6 commits intoome:developfrom
Open
Chunk API: Add new API and functionality for reading and writing chunks#3794dgault wants to merge 6 commits intoome:developfrom
dgault wants to merge 6 commits intoome:developfrom
Conversation
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
joshmoore
reviewed
Feb 22, 2023
| /* @see IFormatWriter#setChunkSize(int[]) */ | ||
| @Override | ||
| public int[] setChunkSize(int[] chunkSize) throws FormatException { | ||
| int[] returnChunkSize = {setTileSizeX(chunkSize[0]), setTileSizeY(chunkSize[1]), 1, 1, 1}; |
Member
There was a problem hiding this comment.
Back to @melissalinkert's question about what would test this code, this could warn or error if a >2D chunk size were requested.
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: |
Member
|
Temporarily excluding since this is scheduled for 8.0.0 and conflicts with things scheduled for 7.1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial prototype of potential new API methods for reading and writing N dimensional chunks of data rather than 2d planes/tiles. These new methods currently have default implementations in FormatReader and FormatWriter than pass through to the current 2D API, so they should be useable. This will be accompanied by a PR on ZarrReader which would be the first instance of a Reader which uses the chunk API by default.
The naming and parameters are all open for debate/suggestions, one of the trickier areas with this is how to handle the DimensionOrder going forward. Currently it is reusing the existing 5D dimensionOrder string.