Document time parsing and warn if time in milliseconds is out of range#4292
Merged
sbesson merged 1 commit intoome:developfrom Apr 25, 2025
Merged
Document time parsing and warn if time in milliseconds is out of range#4292sbesson merged 1 commit intoome:developfrom
sbesson merged 1 commit intoome:developfrom
Conversation
sbesson
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4142.
This is mainly meant to clarify the expectations of
decodeTime(int), namely that it takes the 32-bit int stored in a Metamorph file for the time of day in milliseconds, and converts to a human-readable string timestamp. The actual date is stored separately, so the number of milliseconds should represent less than 24 hours.The only change in behavior should be that there is a warning if the number of milliseconds is outside the bounds of the number of milliseconds in a day (which is much narrower than int32 range). That shouldn't happen in practice with Metamorph data, but is included because this is a public method. I could see a case here for throwing
IllegalArgumentExceptioninstead.