Replace arrayCoordinateSystem with explanation on how to express dimensionless transforms in pixel coordinates#118
Open
jo-mueller wants to merge 7 commits intoome:mainfrom
Open
Replace arrayCoordinateSystem with explanation on how to express dimensionless transforms in pixel coordinates#118jo-mueller wants to merge 7 commits intoome:mainfrom
arrayCoordinateSystem with explanation on how to express dimensionless transforms in pixel coordinates#118jo-mueller wants to merge 7 commits intoome:mainfrom
Conversation
Automated Review URLs |
will-moore
reviewed
Mar 26, 2026
will-moore
reviewed
Mar 26, 2026
Contributor
|
Perfect from my point of view! 🚀 |
d-v-b
reviewed
Mar 27, 2026
d-v-b
reviewed
Mar 28, 2026
index.md
Outdated
| ::: | ||
|
|
||
| **Transformations in pixel units**: Some applications might prefer to define points, regions-of-interest or transformation parameters | ||
| in "pixel coordinates" rather than "physical coordinates". |
Contributor
There was a problem hiding this comment.
Why are the terms "pixel coordinates" and "physical coordinates" in scare quotes?
Contributor
Author
There was a problem hiding this comment.
Likely a remnant of the issue referenced above (unclear semantics around pixels/voxels/arrays). Definitely something I can change.
Contributor
Author
There was a problem hiding this comment.
Cool thanks! Can I count this as tentative PR approval? 👉 👈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ome/ngff#438
Addresses comment 4 on RFC5.
Title. This PR replaces the definition of implicit
arrayCoordinateSystemswith examples and explanatory text on how to properly express transforms that are done in pixel space, not unit space.Follow up PR to #103 and #90
cc @bogovicj @btbest @will-moore @clbarnes @dstansby