Streamline input output constraints#137
Open
jo-mueller wants to merge 5 commits into
Open
Conversation
Automated Review URLs |
clbarnes
requested changes
Jun 11, 2026
|
|
||
| | Field | Type | Required | Description | | ||
| |-------|------|----------|-------------| | ||
| | `type` | string | yes | The type of the transformation, which determines the required and optional fields for that transformation. | |
Contributor
There was a problem hiding this comment.
Suggestion to replace the "required" column with a "requirement level" (or synonym), with MUST/SHOULD/MAY to match spec text.
| |-------|------|----------|-------------| | ||
| | `type` | string | yes | The type of the transformation, which determines the required and optional fields for that transformation. | | ||
| | `name` | string | no | A unique name for this transformation. | | ||
| | `input` | object | yes, unless part of a wrapper transform ([`sequence`](#sequence-md), [`bijection`](#bijection-md), [`byDimension`](#bydimension-md)) | The input coordinate system for this transformation. | |
Contributor
There was a problem hiding this comment.
The Type column, where the type is another object defined in this spec, should use that object's name and link to its definition. But we shouldn't try to change all the definitions into tables in this PR :)
Contributor
Author
There was a problem hiding this comment.
It was tempting 😬 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ome/ngff#523
This removes some duplicate text and adds more descriptive tables to the transformations section to make the whole paragraph a bit easier to read.
cc @btbest