Hardcode version - #33
Merged
Merged
Conversation
jo-mueller
added
bug
Automated Review URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32 Version control tools like
setuptools_scmorhatch-vcskind of reserve the.devtags for themselves to create local development versions (i.e.,0.6.dev1+39487234)so that they are a bit more strict with the dev tags beyond what's written out in PEP440.I reverted to hardcoded versions here so that we can use the
0.6.dev2tag now since it has been disseminated quite a bit. For future releases we can think of a better versioning scheme after a clean release of the0.6tag.I think it's still useful to have the version available in Python to run some checks in the validation/pre_build CI.