Skip to content

Remove S3 handling#108

Open
dominikl wants to merge 2 commits into
ome:masterfrom
dominikl:remove_s3
Open

Remove S3 handling#108
dominikl wants to merge 2 commits into
ome:masterfrom
dominikl:remove_s3

Conversation

@dominikl
Copy link
Copy Markdown
Member

@dominikl dominikl commented Nov 6, 2025

This PR removes minio dependency (and therefore S3 handling, has been deprecated already), it is actually not used anywhere.

@joshmoore
Copy link
Copy Markdown
Member

@sbesson
Copy link
Copy Markdown
Member

sbesson commented Dec 9, 2025

From discussion yesterday at the OME Formats meeting, the current proposal is to deprecate these APIs in Bio-Formats 8.4.0 in preparation for their removal from the ome-common library in Bio-Formats 9. I'll try to get something opened before the end of the calendar year

@dominikl
Copy link
Copy Markdown
Member Author

dominikl commented Feb 2, 2026

S3 methods are deprecated now (#110) I'll resurrect this PR, remove draft and see what breaks downstream (hopefully nothing). @sbesson suggested this might also superseed #109 as jackson dep was probably added just because the S3.

@dominikl dominikl marked this pull request as ready for review May 12, 2026 10:16
@dominikl dominikl requested a review from sbesson May 12, 2026 10:19
@sbesson
Copy link
Copy Markdown
Member

sbesson commented May 12, 2026

Closing/reopening to trigger the CI workflow

@sbesson sbesson closed this May 12, 2026
@sbesson sbesson reopened this May 12, 2026
@dominikl
Copy link
Copy Markdown
Member Author

Thanks Seb. Sorry, didn't see that workflow wasn't triggered.

Copy link
Copy Markdown
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dominikl. Comparing the changes against the content of the original PR which introduced this functionality, noting a few additional places that should be cleaned up:

  • location-server
  • pom.xml: the jackson-* dependencies
  • StreamHandle: the internal Settings class
  • Location:
    • the UrlType enum
    • the isURL, urlType and uri private fields
    • the internal code paths that depend on these enum and fields
    • a few unused imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants