Remove S3 handling#108
Open
dominikl wants to merge 2 commits into
Open
Conversation
Member
|
https://github.com/ome/ome-common-java/blob/master/location-server/start-location.sh can likely go as well. |
Member
|
From discussion yesterday at the OME Formats meeting, the current proposal is to deprecate these APIs in Bio-Formats 8.4.0 in preparation for their removal from the |
Member
Author
Member
|
Closing/reopening to trigger the CI workflow |
Member
Author
|
Thanks Seb. Sorry, didn't see that workflow wasn't triggered. |
sbesson
requested changes
May 15, 2026
Member
sbesson
left a comment
There was a problem hiding this comment.
Thanks @dominikl. Comparing the changes against the content of the original PR which introduced this functionality, noting a few additional places that should be cleaned up:
location-serverpom.xml: thejackson-*dependenciesStreamHandle: the internalSettingsclassLocation:- the
UrlTypeenum - the
isURL,urlTypeanduriprivate fields - the internal code paths that depend on these enum and fields
- a few unused imports
- the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
miniodependency (and therefore S3 handling, has been deprecated already), it is actually not used anywhere.