Remove distributed from dependencies (unused)#441
Merged
joshmoore merged 1 commit intoome:masterfrom Mar 12, 2025
Merged
Conversation
Member
|
Launched and now green. @will-moore: any thoughts? |
Member
|
The dependency was added in fbfd23b#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7 but I don't see it being used any more. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for your work here!
I noticed that although
distributedis listed in the dependencies, as far as I can tell the package is not being used inome-zarr-py. So this PR removes it.Next to cleaning up the dependencies, this can be useful for using
ome-zarr-pywithin WASM-based environments (e.g. jupyter lite), whichdistributedis not compatible with.