Skip to content

Enforce more ruff rules#442

Merged
joshmoore merged 13 commits intoome:masterfrom
DimitriPapadopoulos:ruff
Aug 7, 2025
Merged

Enforce more ruff rules#442
joshmoore merged 13 commits intoome:masterfrom
DimitriPapadopoulos:ruff

Conversation

@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2025

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.99%. Comparing base (bc34123) to head (fb1b681).
⚠️ Report is 96 commits behind head on master.

Files with missing lines Patch % Lines
ome_zarr/utils.py 0.00% 2 Missing ⚠️
ome_zarr/cli.py 0.00% 1 Missing ⚠️
ome_zarr/reader.py 50.00% 1 Missing ⚠️
ome_zarr/writer.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   87.02%   86.99%   -0.03%     
==========================================
  Files          13       13              
  Lines        1772     1769       -3     
==========================================
- Hits         1542     1539       -3     
  Misses        230      230              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft March 12, 2025 19:54
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review March 12, 2025 21:18
@joshmoore
Copy link
Copy Markdown
Member

Apologies, @DimitriPapadopoulos. This is now conflicting. Could you give it a look?

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the ruff branch 2 times, most recently from 66e4582 to 16f1d4d Compare August 7, 2025 19:37
BLE001 Do not catch blind exception
B015 Pointless comparison at end of function scope.
     Did you mean to return the expression result?
LOG009 Use of undocumented `logging.WARN` constant
G004 Logging statement uses f-string
SIM102 Use a single `if` statement instead of nested `if` statements
SIM118 Use `key in dict` instead of `key in dict.keys()`
SIM300 Yoda condition detected
UP006 Use `dict` instead of `Dict` for type annotation
UP007 Use `X | Y` for type annotations
UP045 Use `X | None` for type annotations
PLW2901 `for` loop variable overwritten by assignment target
RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
@joshmoore joshmoore merged commit 35a96eb into ome:master Aug 7, 2025
9 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the ruff branch August 7, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants