Draft
Conversation
NB: dask data not supported
Contributor
|
@will-moore please also see zarr-developers/zarr-python#3612. Though not as neat (would require first writing the data) after that it should create the zip without really having to worry about the metadata as it just gets copied to a zipstore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: this is currently 1 commit on top of #476.
Experimenting with what it would take to support ZipStore, as requested in #363.
Also informed by #478 (comment)
Currently,
write_multiscale()fails to write any metadata attributes to the top-level group when using a ZipStore, becausewrite_multiscales_metadata()happens after the group is created and it is not updatable in a ZipStore.The experimental approach taken here is to generate all the metadata before the group creation happens. This allows us to write the attributes when the group is created.
If the group name (string) ending with ".zip" then we create a zip store:
Limited testing with: