Skip to content

chore: fix defaults for scale factors #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jo-mueller wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

chore: fix defaults for scale factors #567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17f6f69
fix: fix defaults for scale factors
jo-mueller Mar 31, 2026
52fb46a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ome_zarr/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,7 @@ def write_image(
warnings.warn(msg, DeprecationWarning)

scale_factors = [
{d: 2**i if d in SPATIAL_DIMS else 1 for d in dims}
{d: 2 ** i if d in ("y", "x") else 1 for d in dims}
for i in range(1, scaler.max_layer + 1)
]
if scaler.method == "local_mean":
Expand Down Expand Up @@ -964,7 +964,7 @@ def write_labels(
labels: np.ndarray | da.Array,
group: zarr.Group | str,
name: str,
scaler: Scaler | None = Scaler(order=0),
scaler: Scaler | None = None,
scale_factors: list[int] | tuple[int, ...] | list[dict[str, int]] = (2, 4, 8, 16),
method: Methods = Methods.NEAREST,
fmt: Format | None = None,
Expand Down Expand Up @@ -1052,7 +1052,7 @@ def write_labels(
Please use the 'scale_factors' argument instead.
"""
scale_factors = [
{d: 2**i if d in SPATIAL_DIMS else 1 for d in dims}
{d: 2 ** i if d in ("y", "x") else 1 for d in dims}
for i in range(1, scaler.max_layer + 1)
]
warnings.warn(msg, DeprecationWarning)
Expand Down
Loading