Skip to content

Introduce scene class#583

Draft
jo-mueller wants to merge 46 commits into
ome:masterfrom
jo-mueller:introduce-scene-class
Draft

Introduce scene class#583
jo-mueller wants to merge 46 commits into
ome:masterfrom
jo-mueller:introduce-scene-class

Conversation

@jo-mueller

@jo-mueller jo-mueller commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Based on #515

This is a first stab at an ome-zarr-py implementation of the scene metadata/layout that will be part of 0.6. It follows closely and builds upon the design principles of the NgffMultiscales class that's introduced in #515 and mirrors the design of the NgffHCSPlate I propose in #570

TODOs:

  • Add tests
  • Add documentation on how to update/append scenes
  • Keep track internally of underlying graph structures, i.e. in an nx.DiGraph instance?

@jo-mueller jo-mueller added the enhancement New feature or request label May 18, 2026
pre-commit-ci Bot and others added 25 commits May 18, 2026 14:57
jo-mueller and others added 14 commits June 23, 2026 15:59
[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

feat: use ozmp from main

feat: use ozmp from main

fix: correct dependency format

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
tests: fix tests

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

chore: pre-commit fixes

chore: pre-commit fixes

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

chore: precommit fixes
[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

chore: pre-commit fixes

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

chore: fix history

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

chore: fix history

chore: fix garbled rebase
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.99209% with 167 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.16%. Comparing base (9a96549) to head (711efec).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ome_zarr/classes/scene.py 13.21% 151 Missing ⚠️
ome_zarr/classes/image.py 78.37% 16 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9a96549) and HEAD (711efec). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (9a96549) HEAD (711efec)
20 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
- Coverage   86.67%   81.16%   -5.51%     
==========================================
  Files          16       17       +1     
  Lines        2319     2538     +219     
==========================================
+ Hits         2010     2060      +50     
- Misses        309      478     +169     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jo-mueller jo-mueller changed the title WIP: Introduce scene class Introduce scene class Jun 24, 2026
@jo-mueller

Copy link
Copy Markdown
Collaborator Author

@kevinyamauchi ready for beta-testing, I would say. Still missing:

  • OMEZarrImage needs another keyword to pass the axis_type (i.e., channel, displacement). Right now we infer these from the axes kwarg (i.e., czyx), but we 'll need more flexibility once Displacements are multiscales ngff-spec#145 is merged (displacements require axis type "displacement"
  • coordinateTransformations/whatever are currently not parsed into the class on read, which might lead to trouble when building the scene graph and it includes coordinates or displacements
  • waaaaay more testing

@jo-mueller

Copy link
Copy Markdown
Collaborator Author

Also: needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant