Introduce scene class#583
Draft
jo-mueller wants to merge 46 commits into
Draft
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
…/ome-zarr-py into introduce-scene-class
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci feat: use ozmp from main feat: use ozmp from main fix: correct dependency format [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
tests: fix tests [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci chore: pre-commit fixes chore: pre-commit fixes [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci chore: precommit fixes
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci chore: pre-commit fixes [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci chore: fix history [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci chore: fix history chore: fix garbled rebase
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 86.67% 81.16% -5.51%
==========================================
Files 16 17 +1
Lines 2319 2538 +219
==========================================
+ Hits 2010 2060 +50
- Misses 309 478 +169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@kevinyamauchi ready for beta-testing, I would say. Still missing:
|
Collaborator
Author
|
Also: needs a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #515
This is a first stab at an ome-zarr-py implementation of the scene metadata/layout that will be part of 0.6. It follows closely and builds upon the design principles of the
NgffMultiscalesclass that's introduced in #515 and mirrors the design of theNgffHCSPlateI propose in #570TODOs:
nx.DiGraphinstance?