Fix static files links for release build#685
Merged
will-moore merged 2 commits intoApr 23, 2026
Merged
Conversation
Member
|
Flake8 |
Member
|
I can confirm that when I did the addition from this PR onto my I still have a problem with "Open With" though... it does not place the images selected into the figure.... |
Member
|
pwalczysko
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failure to load static files for the 8.0.1.rc1 release (when deployed on outreach server).
This was the first test of installing a release build (different from the local built that is tested by merge-ci).
UPDATE: problem was due to
baseurl being set when we build via gh-actions (used for gh-pages deploy) but gh-actions is also used for release build.Now, we ONLY set
baseurl when we specifically build for gh-pages.I have pushed this branch to my https://github.com/will-moore/omero-figure/tree/master branch so that gh-pages is tested to deploy to https://will-moore.github.io/omero-figure/
To test: gh-pages should still deploy correctly (app works etc) and other deploys work too!