Open
Conversation
Member
Author
|
This was just to aid the discussion at ome/design#99, not to be merged or tested yet... |
However, this doesn't work fully (at least for non-tiled images) since the resulution is always 1 in the setStyle function
Member
Author
will-moore
added a commit
to will-moore/omero-iviewer
that referenced
this pull request
Feb 21, 2019
will-moore
added a commit
to will-moore/omero-iviewer
that referenced
this pull request
Feb 21, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first steps towards support of large numbers of ROIs in iviewer.
PR opened in 2019 and again in 2025, and updated to use an OMERO.table of the Shapes in the Image to support loading shapes by tile/region.
It uses a OpenLayers
VectorTilelayer to load shapes by tile.Setup...
X1, X2, Y1, Y2to define the bounding box of each Shape. OMERO.table has namespaceomero.shape.boundingbox.coords.iviewer/shapes_by_region/IMAGEID/Z/T?tile=ZOOM,ROW,COL,WIDTH,HEIGHTrequest opens the table, finds rows that have an intersecting bounding box and uses theshape_idto load the shapes from OMERO.Limitations / questions:
VectorTilelayer andTiledRegionssource instead of theVectorlayer andsource/Regionsclass. This means that all the shape drawing and manipulation code in thesource/Regionsclass is not available, so we can't drag, edit or draw shapes. If we want to support this in future we could possibly:VectorTilelayer for showing existing shapes and add aVector layer + Regionsoverlay to allow drawing new shapes.TiledRegionssource. This would probably involve splitting the existingsource/Regionsclass to separate the drawing & editing code from theol.source.Vectorbase class to allow reuse. Possibly a lot of refactoring!Testing
<and next>buttons and a range slider) and reload ROIs for the chosen page.