Skip to content

Channel min spinner fix#460

Open
will-moore wants to merge 2 commits intoome:masterfrom
will-moore:channel_min_spinner_fix
Open

Channel min spinner fix#460
will-moore wants to merge 2 commits intoome:masterfrom
will-moore:channel_min_spinner_fix

Conversation

@will-moore
Copy link
Copy Markdown
Member

Fixes issues for 'start' channel slider input as reported at ome/ZarrReader#67 (comment).

  • With a very large negative number, the formatting of the number as required for floats was resulting in Nan.
  • Also, the spinner behaviour (jQuery plugin) doesn't work with very large negative numbers. Reducing the minimum number fixes this issue.

Without this limit, entering values into the field can get modified or rounded massively
@jburel
Copy link
Copy Markdown
Member

jburel commented Nov 21, 2023

is the change deployed on idr-testing?

@jburel
Copy link
Copy Markdown
Member

jburel commented May 13, 2024

Does this PR need to be considered for the upcoming release?

@will-moore
Copy link
Copy Markdown
Member Author

I tried to find images where this bug was still showing, so as to demonstrate the fix, but e.g. with the image reported originally I don't see this issue any more: https://idr-testing.openmicroscopy.org/webclient/img_detail/10648053/

It's possible that some other dependency update addressed the issue? 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants