Skip to content

Fix roi link permissions#517

Open
will-moore wants to merge 1 commit intoome:masterfrom
will-moore:fix_roi_link_permissions
Open

Fix roi link permissions#517
will-moore wants to merge 1 commit intoome:masterfrom
will-moore:fix_roi_link_permissions

Conversation

@will-moore
Copy link
Copy Markdown
Member

@will-moore will-moore commented Mar 20, 2026

Fixes issue reported at https://forum.image.sc/t/rois-link-in-omero-table-not-working/119676/4 where we failed to use a "cross-group" query, so a link to ROI in iviewer didn't work if the ROI wasn't in your default group.

To test:

  • As user-3 on merge-ci, login and then enter URL /web/iviewer/?roi=3819 (that ROI is owned by user-3 but not in their default group)
  • Currently this fails with Error dialog in iviewer
  • This should find the correct image and open it in iviewer

@will-moore will-moore force-pushed the fix_roi_link_permissions branch from 3556ffb to 3e5a2cf Compare March 20, 2026 15:55
@will-moore will-moore requested a review from pwalczysko March 23, 2026 14:10
@pwalczysko
Copy link
Copy Markdown
Member

I was able to repeat the bug on outreach server:

In default group, the link to a ROI works fine.
In non-default group, the link to a ROI fails with error dialog in iviewer

With this PR:

Works as expected. I am noting that the ROI is in a non-default group of user-3

Maybe for another PR:
I am seeing an uinexpected behaviour with another link connected to iviewer. On the very ROI https://merge-ci.openmicroscopy.org/web/iviewer/?roi=3819, select the Info tab in RHP, then click on Image ID (4003). Observe that the image does not get selected in webclient (the Dataset just beneath it does if clicked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants