omero.gateway: fix DetailsWrapper.getExternalInfo regression#482
Merged
sbesson merged 3 commits intoome:masterfrom Oct 3, 2025
Merged
omero.gateway: fix DetailsWrapper.getExternalInfo regression#482sbesson merged 3 commits intoome:masterfrom
sbesson merged 3 commits intoome:masterfrom
Conversation
This test should pass with OMERO.py 5.20.0 but fail with OMERO.py 5.21.0
knabar
approved these changes
Oct 1, 2025
Member
knabar
left a comment
knabar
left a comment
There was a problem hiding this comment.
This looks like a reasonable solution to the issue, with the old behavior of .getDetails().getExternalInfo() restored. It is a bit unfortunate that the return type of .getExternalInfo() on a non-details object is different, but since that call did not exist before at all, it's probably better to keep it the same to when it was introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481
6e521bb adds a simple unit test capturing the regression. The test should pass with OMERO.py 5.20.0 but fail with OMERO.py 5.21.0 or 5.21.1.
1fd4c4d fixes the regression by overriding
BlitzObjectWrapper.getExternalInfo()forDetailsWrapper69841a5 adds some coverage for the API introduced in #453
The tests have been initially limited to the scope of
ImageWrapperbut happy to extend them to cover other wrappers if there is an authoritative list of the types we'd like to support.