-
Notifications
You must be signed in to change notification settings - Fork 39
externalInfo display #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
externalInfo display #613
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cac3aa7
Show externalInfo in right panel if available
will-moore aeb7536
Move External info under Filset info panel
will-moore a8c190b
Pass obj to toolbar.html for all objects. Tweak extInfo css
will-moore cca34cb
Only show ExternalInfo on .show()
will-moore f3c42d3
Show externalInfo with 'Zarr' button. Link to open in BioNGFF viewer
will-moore 189a107
Remove console.log
will-moore b1e46a8
Remove zarr link to viewer. Show lsid only, other info under 'details'
will-moore 3112dd8
Use obj.getDetails().getExternalInfo()
will-moore e9cbf53
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] eaf08da
Add None check
will-moore 0f025c6
Cleanup template endif to reduce PR diff
will-moore 407021a
Remove outdated comment
will-moore 442803a
Only show 'Zarr' button if externalInfo is ngff:multiscales
will-moore 17beaf1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4a4dd41
Don't require extinfo.entityId == 3 to be considered a zarr
will-moore 2c98dff
Remove external info specifics
knabar 6aa270d
Add template blocks
knabar 77aed96
Merge pull request #4 from knabar/extinfo_display
will-moore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,6 +150,11 @@ | |
| }); | ||
|
|
||
| {% endif %} | ||
|
|
||
| $("#show_ext_info").on("click", function() { | ||
| var $panel = $("#externalInfo"); | ||
| $panel.toggle(); | ||
| }); | ||
|
|
||
| }); | ||
| </script> | ||
|
|
@@ -348,10 +353,12 @@ | |
| </li> | ||
| {% endwith %} | ||
| {% endif %} | ||
| {% endif %} | ||
| {% endif %} <!-- endif image --> | ||
| </ul> | ||
| </div> | ||
|
|
||
| {% endif %} <!-- endif image or filesetInfo --> | ||
|
|
||
| {% if not share %} | ||
| {% if image.showOriginalFilePaths %} | ||
| <!-- show original file paths --> | ||
|
|
@@ -366,7 +373,6 @@ | |
| </button> | ||
| {% endif %} | ||
| {% endif %} | ||
| {% endif %} | ||
|
|
||
|
|
||
| <!-- Publishing Options (Figure Scripts) --> | ||
|
|
@@ -375,6 +381,17 @@ | |
| {% include "webclient/annotations/includes/figure_scripts_menu.html" %} | ||
| {% endif %} | ||
| {% endif %} | ||
|
|
||
| <!-- External Info (Zarr url)--> | ||
| {% with extinfo=obj.getExternalInfo %} | ||
| {% if extinfo %} | ||
| <button id="show_ext_info" class="btn silver btn_extinfo" title="Zarr url" > | ||
| <span style="width: 25px; margin: 3px 2px 1px 2px; background: transparent; box-shadow: none; font-size: 11px; padding: 0px;"> | ||
| Zarr | ||
| </span> | ||
| </button> | ||
| {% endif %} | ||
| {% endwith %} | ||
|
|
||
|
|
||
|
|
||
|
|
@@ -424,3 +441,25 @@ | |
| <input type="text" size="30"> | ||
| <img title="Close" src="{% static 'webgateway/img/close.gif' %}" /> | ||
| </div> | ||
|
|
||
| <!-- This is hidden initially --> | ||
| <div id="externalInfo" style="display: none; margin-top: 15px; font-size: 13px;"> | ||
| <!-- This will return None if obj.getExternalInfo method doesn't exist (omero-py 5.19.6 and earlier) --> | ||
| {% with extinfo=obj.getExternalInfo %} | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NB: with ome/omero-py#483 this should now be |
||
| {% if extinfo %} | ||
|
|
||
| <div style="background: white; padding: 7px; border: 1px solid rgb(221, 221, 221); overflow: auto; border-radius: 4px;"> | ||
| <h3>Zarr Info</h3> | ||
| <div style="margin: 8px 0; word-wrap: break-word"><strong>{{ extinfo.lsid.val }}</strong></div> | ||
| <details> | ||
| <summary>Details</summary> | ||
| <ul style="margin: 5px"> | ||
| <li>externalInfo ID: <strong>{{ extinfo.id.val }}</strong></li> | ||
| <li>entityType: <strong>{{ extinfo.entityType.val }}</strong></li> | ||
| <li>entityId: <strong>{{ extinfo.entityId.val }}</strong></li> | ||
| </ul> | ||
| </details> | ||
| </div> | ||
| {% endif %} | ||
| {% endwith %} | ||
| </div> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: with ome/omero-py#483 this should now be
obj.getDetails().getExternalInfo()