Skip to content

Include plate acquisition start time even if end time is missing - #666

Merged
knabar merged 1 commit into
ome:masterfrom
melissalinkert:plate-acquisition-naming
May 20, 2026
Merged

Include plate acquisition start time even if end time is missing#666
knabar merged 1 commit into
ome:masterfrom
melissalinkert:plate-acquisition-naming

Conversation

@melissalinkert

Copy link
Copy Markdown
Member

This adds an extra case to the logic for setting the plate acquisition
name in the tree in the left-hand panel. If a start time (but not an
end time) was set, then the name will be the start time instead of Run $id.

To test, import plate-acquisition-test.ome.xml, which is a simple single-well plate with no EndTime on the PlateAcquisition. Verify that the starttime on plateacquisition is set to a valid timestamp in the database. Open the same plate in OMERO.web without this change, and verify that the corresponding plate acquisition is listed in the left-hand panel tree as Run followed by the ID number. With this change, open the plate again (no need to reimport) and verify that the plate acquisition is now listed as a timestamp matching the value of starttime.

@will-moore

will-moore commented Mar 5, 2026

Copy link
Copy Markdown
Member

This seems to be working fine (once I'd worked out that the ome.xml sample above has the Acquisition name set to PlateAcquisition Name 0, so the timestamps weren't being used).

Before this PR:

Screenshot 2026-03-05 at 15 51 51

With this PR:

Screenshot 2026-03-05 at 15 50 47

@sbesson
sbesson requested a review from knabar March 10, 2026 16:58
@knabar knabar modified the milestones: 5.32.0, 5.31.1 May 12, 2026
@knabar
knabar merged commit 71bcda0 into ome:master May 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants