Webclient activites: defensively cast start_time to string - #670
Merged
Conversation
As part of the Django 5.2 upgrade work, start times of callbacks are serialized as strings. Various error messages suggest there are still conditions under which datetime and string objects are directly compared when sorting jobs which is illicit. This commit fixes the sorting by ensuring strings are always compared.
knabar
approved these changes
Mar 27, 2026
will-moore
approved these changes
Mar 27, 2026
will-moore
left a comment
will-moore
left a comment
Member
There was a problem hiding this comment.
Looks good. Sorting strings will be fine 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #652
As part of the Django 5.2 upgrade work, start times of callbacks are serialized as strings. Various error messages suggest there are still conditions under which datetime and string objects are directly compared when sorting jobs which is illicit. This commit fixes the sorting by ensuring strings are always compared.
As we have not identified how to reproduce the original issue, functional testing should probably validate that the activities endpoint still works as expected with various jobs submitted and in-between restarts of the application