Initial support for JSON api /annotations endpoint - #682
Open
will-moore wants to merge 5 commits into
Open
Conversation
knabar
changed the title
This was referenced Jul 1, 2026
This was referenced Jul 30, 2026
will-moore
force-pushed
the
api_annotations
branch
from
July 31, 2026 13:08
674eca6 to
c641f1e
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
pwalczysko
reviewed
Aug 3, 2026
| """Override get() to allow filtering by annotation type.""" | ||
|
|
||
| # set self.OMERO_TYPE, then call super().get() to get the list of Annotations | ||
| # E.g. conn.getObjects("TagAnnotation") - not actually case-sensitive |
Member
There was a problem hiding this comment.
I think that the tests of test_show in https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-test-integration/lastCompletedBuild/testReport/ might be failing because of this change - the timing of the commit and the timing of the tests starting to fail matches.
Member
|
excluded to verify #682 (comment) |
Member
wrong call, including again, sorry |
Member
|
Member
|
Excluding again, as this PR is coupled with ome/openmicroscopy#6459 and ome/omero-py#489. Will exclude all three to be sure, thanks @sbesson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #532 - also discussed at #635
This wraps ome/omero-py#489 and passes query parameters to getObjects().
Adds support for
/api/v0/m/annotations/endpoint, with various query parameters:E.g: