Detected configurable modules when ini key is absent.#2437
Open
Daniel-KM wants to merge 1 commit intoomeka:developfrom
Open
Detected configurable modules when ini key is absent.#2437Daniel-KM wants to merge 1 commit intoomeka:developfrom
Daniel-KM wants to merge 1 commit intoomeka:developfrom
Conversation
Daniel-KM
force-pushed
the
feat/detect_configurable
branch
from
8e6cca9 to
b012a5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file module.ini contains metadata about the module. The key "configurable" is more internal and has no real reason to be inside it. So it should be moved to module.config.php, in a section for modules. But in fact, it is useless, it can be determined automatically. So this pr make it possible to remove the key in module.ini without adding it in module.config.php. Furthermore, it may simplify the use of composer, that has all the same keys than module.ini except this one.