Enforce sort direction in dql. Do not allowing ordering when disabled.

[craigh]

closes #388

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (1555e12) to head (d39e207).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          40       40           
  Lines        1078     1078           
=======================================
  Hits         1019     1019           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Chris53897]

@craigh Could you please check the default-order?

The actual code changed our existing sorting. I need to investigate further

[Chris53897]

Could you please add a mb_strtolower() for comparison.

We use in our code
->addOrderBy('fieldA', 'ASC')

[craigh]

@Chris53897 done

[craigh]

ping @curry684

[curry684]

As noted at #388 (comment) I would revert injecting semi-SQL here as it's confusing. Do the input sanitation tests in the new test case.

[curry684]

I'll merge it and shuffle the tests a bit.

[curry684]

Hrm no I'm reverting it as it's going to cause a lot of new problems. The ordering option only controls whether the user can change the ordering, it's a DataTables option. Setting it to false should NOT block the developer from applying a fixed ordering.