Pull and push updated token metadata#47
Open
k1rill-fedoseev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add functionality for updating metadata inside of bridged tokens. Currently, it is possible to update
tokenURIandownerfields only. But this can be extended further whenever needed.Updates in home bridged tokens are managed through the async information calls AMB feature, so no foreign transactions will be required (the updates are being "pulled" from the foreign side).
Updates in foreign bridged tokens are managed through regular AMB messages, using
requireToPassMessage(the updates are being "pushed" to the foreign side).The foreign contract is designed in such a way, so that it can be reused in the future without expensive upgrades, if adding more metadata fields will be necessary.