Fix CoreGraphics imports for modern Xcode - #105
Open
XStylus wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates two OmniFoundation headers to import
CoreGraphics/CGGeometry.hdirectly before using CoreGraphics geometry types.OFExtent.handOFGeometry.huse types such asCGFloat,CGRect, andCGSize. On modern Xcode/macOS SDK combinations, those types are not reliably available through the existing macOS-sideFoundation/NSGeometry.himport alone.Making the CoreGraphics import explicit avoids relying on an indirect SDK include relationship.
Changes
CoreGraphics/CGGeometry.honce at the top ofOFExtent.h.CoreGraphics/CGGeometry.honce at the top ofOFGeometry.h.Foundation/NSGeometry.handUIKit/UIGeometry.himports in place.Verification
Verified locally with Xcode 26.5: