Skip to content

Support subclassing Connection#106

Open
PikalaxALT wants to merge 1 commit into
omnilib:mainfrom
PikalaxALT:patch-1
Open

Support subclassing Connection#106
PikalaxALT wants to merge 1 commit into
omnilib:mainfrom
PikalaxALT:patch-1

Conversation

@PikalaxALT

Copy link
Copy Markdown

Description

Add cls kwarg to core.connect that is a subclass or Connection (or a Callable[[Callable[[Any], sqlite3.Connection], int], Connection]) (default: Connection)

Example usage:

class MyConnection(aiosqlite.Connection):
    ...

async def main():
    conn = await aiosqlite.connect(':memory:', cls=MyConnection)
    # use methods and attrs of MyConnection

Current workaround: connect must be redefined to explicitly call your custom async connection factory.

Add `cls` kwarg to `core.connect` that is a subclass or Connection (or a `Callable[[Callable[[Any], sqlite3.Connection], int], Connection]`) (default: `Connection`)
@amyreese

Copy link
Copy Markdown
Member

Sounds good. Can you add a simple test case covering this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants