fix: close connection thread properly if BaseException raised in connect step#317
Merged
amyreese merged 1 commit intoomnilib:mainfrom Feb 3, 2025
gpajot:dev
Merged
fix: close connection thread properly if BaseException raised in connect step#317amyreese merged 1 commit intoomnilib:mainfrom gpajot:dev
amyreese merged 1 commit intoomnilib:mainfrom
gpajot:dev
Conversation
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the
Connection._connectmethod currently only catchesException(and notBaseException), if one is raised, the connection thread won't be closed and the program will hang on exit.Fixes: close connection thread properly if
BaseExceptionraised in connect step