fix #151 Zadm->Validator->zoneNic should validate $name against list of physical nics#152
Merged
Conversation
hadfl
reviewed
Jul 1, 2025
hadfl
left a comment
hadfl
left a comment
Member
There was a problem hiding this comment.
While you are on it, could you please rename the $name parameter to $nic and $nic to $net as I mentioned it in the issue?
This way we'll match the property naming in the globalNic validator, leading to less confusion.
hadfl
approved these changes
Jul 1, 2025
oetiker
approved these changes
Jul 2, 2025
oetiker
left a comment
oetiker
left a comment
Member
There was a problem hiding this comment.
Extremely well hidden action at a distance to fix the problem on line 171 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.