-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add CI verification targets and PR checks #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c6f0c14
fix: migrate eslint config to typescript-eslint v8 + @stylistic
joshuapare 9f19394
feat: add CI verification targets and PR checks workflow
joshuapare cec6081
fix: resolve CI failures for PR checks
joshuapare ca1e012
fix: address code review findings
joshuapare 7ea9836
fix: pin CI node/pnpm versions to .tool-versions, require goimports
joshuapare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| name: PR Checks | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| concurrency: | ||
| group: pr-checks-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| GO_VERSION: "1.26" | ||
| NODE_VERSION: "20.18.1" | ||
| PNPM_VERSION: "9.15.0" | ||
|
|
||
| jobs: | ||
| go-checks: | ||
| name: Go checks | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: ${{ env.GO_VERSION }} | ||
| cache: true | ||
|
|
||
| - name: Build | ||
| run: make go-build | ||
|
|
||
| - name: Vet | ||
| run: make go-vet | ||
|
|
||
| - name: Test | ||
| run: make go-test | ||
|
|
||
| - name: Format check | ||
| run: make fmt-check | ||
| continue-on-error: true | ||
|
|
||
| - name: Lint | ||
| uses: golangci/golangci-lint-action@v6 | ||
| with: | ||
| version: v2.1 | ||
| args: run | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| env: | ||
| GOWORK: "off" | ||
| continue-on-error: true | ||
|
|
||
| bindings-check: | ||
| name: Bindings freshness | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: ${{ env.GO_VERSION }} | ||
| cache: true | ||
|
|
||
| - name: Install wails | ||
| run: go install github.com/wailsapp/wails/v2/cmd/wails@v2.11.0 | ||
|
|
||
| - name: Check bindings are up to date | ||
| run: make bindings-check | ||
|
|
||
| ui-checks: | ||
| name: UI checks | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ env.NODE_VERSION }} | ||
|
|
||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: ${{ env.PNPM_VERSION }} | ||
|
|
||
| - name: Get pnpm store directory | ||
| id: pnpm-cache | ||
| shell: bash | ||
| run: echo "STORE_PATH=$(pnpm store path)" >> $GITHUB_OUTPUT | ||
|
|
||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: ${{ steps.pnpm-cache.outputs.STORE_PATH }} | ||
| key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
| restore-keys: ${{ runner.os }}-pnpm-store- | ||
|
|
||
| - name: Install dependencies | ||
| run: make ui-install | ||
|
|
||
| - name: Build | ||
| run: make ui-build | ||
|
|
||
| - name: Lint | ||
| run: make ui-lint | ||
| continue-on-error: true | ||
|
|
||
| - name: Typecheck | ||
| run: make ui-typecheck | ||
| continue-on-error: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,7 @@ lerna-debug.log* | |
|
|
||
| node_modules | ||
| dist | ||
| !dist/.gitkeep | ||
| dist-ssr | ||
| *.local | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.