-
Notifications
You must be signed in to change notification settings - Fork 3
fix: keep log viewer pinned during drawer resize and minimize/reexpand #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9590e6b
fix: keep log viewer pinned to bottom during drawer resize and restor…
joshuapare 04dd6db
fix: use double rAF in restore-from-minimized branch to match follow-…
joshuapare 4fd7c6b
fix: use callback ref so ResizeObserver attaches when scroll containe…
joshuapare e483d23
fix: anchor saved scroll position by timestamp instead of index
joshuapare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anchor restore to a unique log entry.
Saving only
entry.timestampmakes this restore ambiguous:findEntryIndexByTime()returns the first row withtimestamp >= target, so duplicate timestamps snap back to the earliest sibling instead of the row that was actually visible. Save a composite anchor for the visible entry (for exampletimestamp + sourceId + lineNumber) and resolve that exact row first, falling back to the timestamp lookup only if the entry has been evicted or filtered out.🔧 Suggested change
Also applies to: 194-203, 217-219
🤖 Prompt for AI Agents