Skip to content

feat: add npm packages as shared plugin dependencies #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuapare merged 1 commit into from
Mar 28, 2026
Merged

feat: add npm packages as shared plugin dependencies #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"@mui/material": "^7.3.0",
"@mui/x-charts": "^8.27.0",
"@mui/x-date-pickers": "^8.27.0",
"@omniviewdev/ai-ui": "^0.1.0",
"@omniviewdev/base-ui": "^0.1.0",
"@omniviewdev/editors": "^0.1.0",
Comment on lines +32 to +34

@coderabbitai coderabbitai Bot Mar 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify the new packages exist on npm and check their latest versions
for pkg in "@omniviewdev/ai-ui" "@omniviewdev/base-ui" "@omniviewdev/editors"; do
  echo "=== Checking $pkg ==="
  npm view "$pkg" version 2>/dev/null || echo "Package not found or not published"
done

Repository: omniviewdev/omniview

Length of output: 193

Consider pinning exact versions for early-stage packages.

All three @omniviewdev/* packages (ai-ui, base-ui, editors) exist on npm at 0.1.0. However, with 0.x semver, minor version bumps can introduce breaking changes. For stability during early development, consider pinning to exact versions ("0.1.0") instead of caret ("^0.1.0"), or at minimum use tilde ("~0.1.0").

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` around lines 32 - 34, Update dependency entries for the three
early-stage packages to avoid unintended breaking changes by replacing the caret
ranges with pinned or tilde versions: change "@omniviewdev/ai-ui": "^0.1.0",
"@omniviewdev/base-ui": "^0.1.0", and "@omniviewdev/editors": "^0.1.0" to either
exact pins ("0.1.0") or conservative ranges using tilde ("~0.1.0") so builds
remain stable while these packages are v0.x.

"@omniviewdev/providers": "workspace:*",
"@omniviewdev/runtime": "workspace:*",
"@omniviewdev/ui": "workspace:*",
Expand Down
14 changes: 14 additions & 0 deletions packages/omniviewdev-vite-plugin/shims/_omniviewdev__ai-ui.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Auto-generated shim for '@omniviewdev/ai-ui'
// DO NOT EDIT -- regenerate with: pnpm --filter @omniviewdev/vite-plugin generate-shims

const mod = window.__OMNIVIEW_SHARED__['@omniviewdev/ai-ui'];

if (!mod) {
throw new Error(
'[omniview] Shared dependency "@omniviewdev/ai-ui" is not available on window.__OMNIVIEW_SHARED__. ' +
'Ensure the Omniview host app is running and shared deps are exported before loading this plugin.'
);
}

// Default export: prefer mod.default, fall back to the module namespace itself.
export default mod.default !== undefined ? mod.default : mod;
14 changes: 14 additions & 0 deletions packages/omniviewdev-vite-plugin/shims/_omniviewdev__ai-ui__styles.css.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Auto-generated shim for '@omniviewdev/ai-ui/styles.css'
// DO NOT EDIT -- regenerate with: pnpm --filter @omniviewdev/vite-plugin generate-shims

const mod = window.__OMNIVIEW_SHARED__['@omniviewdev/ai-ui/styles.css'];

if (!mod) {
throw new Error(
'[omniview] Shared dependency "@omniviewdev/ai-ui/styles.css" is not available on window.__OMNIVIEW_SHARED__. ' +
'Ensure the Omniview host app is running and shared deps are exported before loading this plugin.'
);
}

// Default export: prefer mod.default, fall back to the module namespace itself.
export default mod.default !== undefined ? mod.default : mod;
14 changes: 14 additions & 0 deletions packages/omniviewdev-vite-plugin/shims/_omniviewdev__base-ui.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Auto-generated shim for '@omniviewdev/base-ui'
// DO NOT EDIT -- regenerate with: pnpm --filter @omniviewdev/vite-plugin generate-shims

const mod = window.__OMNIVIEW_SHARED__['@omniviewdev/base-ui'];

if (!mod) {
throw new Error(
'[omniview] Shared dependency "@omniviewdev/base-ui" is not available on window.__OMNIVIEW_SHARED__. ' +
'Ensure the Omniview host app is running and shared deps are exported before loading this plugin.'
);
}

// Default export: prefer mod.default, fall back to the module namespace itself.
export default mod.default !== undefined ? mod.default : mod;
14 changes: 14 additions & 0 deletions packages/omniviewdev-vite-plugin/shims/_omniviewdev__base-ui__styles.css.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Auto-generated shim for '@omniviewdev/base-ui/styles.css'
// DO NOT EDIT -- regenerate with: pnpm --filter @omniviewdev/vite-plugin generate-shims

const mod = window.__OMNIVIEW_SHARED__['@omniviewdev/base-ui/styles.css'];

if (!mod) {
throw new Error(
'[omniview] Shared dependency "@omniviewdev/base-ui/styles.css" is not available on window.__OMNIVIEW_SHARED__. ' +
'Ensure the Omniview host app is running and shared deps are exported before loading this plugin.'
);
}

// Default export: prefer mod.default, fall back to the module namespace itself.
export default mod.default !== undefined ? mod.default : mod;
14 changes: 14 additions & 0 deletions packages/omniviewdev-vite-plugin/shims/_omniviewdev__editors.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Auto-generated shim for '@omniviewdev/editors'
// DO NOT EDIT -- regenerate with: pnpm --filter @omniviewdev/vite-plugin generate-shims

const mod = window.__OMNIVIEW_SHARED__['@omniviewdev/editors'];

if (!mod) {
throw new Error(
'[omniview] Shared dependency "@omniviewdev/editors" is not available on window.__OMNIVIEW_SHARED__. ' +
'Ensure the Omniview host app is running and shared deps are exported before loading this plugin.'
);
}

// Default export: prefer mod.default, fall back to the module namespace itself.
export default mod.default !== undefined ? mod.default : mod;
14 changes: 14 additions & 0 deletions packages/omniviewdev-vite-plugin/shims/_omniviewdev__editors__styles.css.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// Auto-generated shim for '@omniviewdev/editors/styles.css'
// DO NOT EDIT -- regenerate with: pnpm --filter @omniviewdev/vite-plugin generate-shims

const mod = window.__OMNIVIEW_SHARED__['@omniviewdev/editors/styles.css'];

if (!mod) {
throw new Error(
'[omniview] Shared dependency "@omniviewdev/editors/styles.css" is not available on window.__OMNIVIEW_SHARED__. ' +
'Ensure the Omniview host app is running and shared deps are exported before loading this plugin.'
);
}

// Default export: prefer mod.default, fall back to the module namespace itself.
export default mod.default !== undefined ? mod.default : mod;
8 changes: 8 additions & 0 deletions packages/omniviewdev-vite-plugin/src/sharedPackages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ export const SHARED_PACKAGES: readonly string[] = [
'@omniviewdev/runtime/runtime',
'@omniviewdev/runtime/models',

// @omniviewdev npm packages (base-ui, ai-ui, editors)
'@omniviewdev/base-ui',
'@omniviewdev/base-ui/styles.css',
'@omniviewdev/ai-ui',
'@omniviewdev/ai-ui/styles.css',
'@omniviewdev/editors',
'@omniviewdev/editors/styles.css',

// DND Kit
'@dnd-kit/core',
'@dnd-kit/modifiers',
Expand Down
Loading
Loading