Forward flags when loading to creation#1051
Conversation
|
We are actually considering introducing a headers mechanism to files similar to |
|
Thanks, @omry for your quick reply. I am not familiar with that header mechanism you mentioned, thus don't immediately see how these are conflicting. |
|
I will let @Jasha10 decide on accepting this. |
|
I understand, thanks for the explanation. |
|
Thanks for the PR, @famura! Let's leave this PR open for now and re-evaluate one we make progress on the header support that Omry mentioned. |
What?
This is a minimal PR providing the possibibility to pass the same flags to
OmegaConf.load()that can be used when callingOmegaConf.create().Why?
I created a custom resolver that allows setting tuples as config values.
It worked perfectly when testing it like this
OmegaConf.create("tup: ${as_tuple:1,2,3}").However, it failed when loading the config file
since I am calling
OmegaConf.resolve()afterOmegaConf.load()(for a good reason that is out of scope here).The error was
I could resolve that error by altering the
allow_objectsflagDespite the disclaimers in the comments about the flags API, I think it would be nice to be able to directly set them when creating a config from a file the same way we can do it when creating it programmatically.
What do you think? Did I miss anything?
How?
Please see the code. The change is straightforward.