devbox new subcommand - #16
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 99.76% 99.79% +0.03%
==========================================
Files 17 18 +1
Lines 2938 3372 +434
==========================================
+ Hits 2931 3365 +434
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Assisted-by: Codex.app:GPT-5.4
Assisted-by: Codex.app:GPT-5.4
Assisted-by: Codex.app:GPT-5.4
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the local devbox new flow for creating a READY DevBox project record from an AMI without launching an EC2 instance, and refactors shared AMI lookup/client injection utilities used by launch, snapshot, and manager code.
Changes:
- Added
devbox.newproject creation implementation and tests. - Extended the Click
newcommand with instance/key defaults and shared param-prefix validation. - Added
utils.get_image()and refactored AMI lookups across launch, snapshots, and manager code.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/devbox/new.py |
Adds standalone/programmatic project creation flow. |
src/devbox/cli.py |
Wires devbox new options and shared param-prefix validation. |
src/devbox/utils.py |
Adds injectable AWS helpers and shared AMI lookup helper. |
src/devbox/launch.py |
Uses shared AMI lookup for volume and SSH username handling. |
src/devbox/lifecycle/snapshots.py |
Uses shared AMI lookup during cleanup and mapping creation. |
src/devbox/devbox_manager.py |
Uses shared AMI lookup when deleting AMI snapshots. |
tests/test_new.py |
Adds unit coverage for new project creation and standalone entrypoint. |
tests/test_cli.py |
Adds CLI coverage for new and param-prefix env behavior. |
tests/test_utils.py |
Adds helper injection and AMI lookup tests. |
tests/test_launch.py |
Adds/updates launch username and missing AMI metadata tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assisted-by: Codex.app:GPT-5.4
Assisted-by: Codex.app:GPT-5.4
ethanholz
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although parts of the
devbox newcommand got committed accidentally in other PRs, it looks like I never managed to actually get the code that did thenewimplementation merged in.The idea here is to theoretically separate the
newandlaunchsubcommands. We can still create on launch, but ideally we'll refactor to reuse thenewparameters first, allowing a cleaner code path.