[WIP] Authorizables and authorization checks - #53
Open
dwhswenson wants to merge 1 commit into
Open
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 34.55% 34.79% +0.24%
==========================================
Files 20 23 +3
Lines 848 957 +109
==========================================
+ Hits 293 333 +40
- Misses 555 624 +69
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will introduce a new task, which checks that all the authorization is working. This is likely to be an occasional source of errors in all the automated workflows, so it is worth creating an easy tool to check it.
The main idea here is to use a abstract mix-in on the three classes that have some sort of authorization (
Bot,Inbox, andSMTP). Subclasses need to define a method that raises exceptions if authorization fails, or returnsTrueif it succeeds. They also need to define which exception classes are expected as indicators of authorization failure.The reason to pass the exception along instead of just returning
Falseis that the exception will usually contain more information about the nature of the failure. This is probably something we want to report to the user.Testing is going to be a bit tricky, I think, because I want this to actually be an integration test. We'll have to skip these in cases where the necessary environment variables aren't provided.