FEAT - Add text to star selections in Add Review form #573
Conversation
…te, defaulted to system
…e-dev` for container
.yarnrc.yml; update ReviewForm.tsx to add pill and text to stars with correpsonding
…olors on review form add text and pill to stars with corresponding colors on review form; make pills dynamically sized width fix #410
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
root
release
source
pages
firebase
context
workflows
devcontainer
globals
labels
|
This pull request is stale because it has been open for 60 days with no activity. |
| @@ -93,6 +102,11 @@ const ReviewForm = ({ | |||
|
|
|||
| const { setAlert } = useAlert(); | |||
| const [userReviews, setUserReviews] = useState<TUserReviews>({}); | |||
| const [difficultyValue, setDifficultyValue] = useState<TRatingScale | null>( | |||
There was a problem hiding this comment.
In globals/types.ts we have a type defined called TNullable which aliases T | null (e.g., useState<TNullable<TRatingScale>>(...) here, rather than useState<TRating | null>(...), where T is TRatingScale)
This also pertains to some other instances below in the added code/changes too FYI
There was a problem hiding this comment.
Okay thanks for the heads up. I'll take a look and fix it
| # This workflow will triage pull requests and apply a label based on the | ||
| # paths that are modified in the pull request. | ||
| # | ||
| # To use this workflow, you will need to set up a .github/labeler.yml | ||
| # file with configuration. For more information, see: | ||
| # https://github.com/actions/labeler | ||
|
|
||
| name: Labeler | ||
| on: [pull_request_target] | ||
|
|
||
| jobs: | ||
| label: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Add label | ||
| uses: actions/labeler@v5 | ||
| with: | ||
| repo-token: '${{ secrets.GITHUB_TOKEN }}' |
There was a problem hiding this comment.
I think this might've been deleted inadvertently post-merge; this should still appear/exist, based on current main
|
This pull request is stale because it has been open for 60 days with no activity. |
No description provided.