Open
Conversation
ukanga
force-pushed
the
fix/pin-delete-submissions-to-master
branch
2 times, most recently
from
35e472a to
75e130f
Compare
delete_xform_submissions and its async wrapper lack @use_master, so the submission_count correction reads from a replica that may have replication lag. The stale count matches num_of_submissions, skipping the correction entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
delete_xform_submissions and its async wrapper lack @use_master, so the submission_count correction reads from a replica that may have replication lag. The stale count matches num_of_submissions, skipping the correction entirely.
Steps taken to verify this change does what is intended
Existing tests still pass.
Side effects of implementing this change
None
Before submitting this PR for review, please make sure you have:
Closes #