Skip to content

Conversation

@tfrg
Copy link
Contributor

@tfrg tfrg commented Dec 29, 2024

What type of PR is this?

  • feature

What this PR does:

  • Make RPC endpoint configurable in GnoWalletProvider to support dynamic RPC URLs

Changes:

  • Add RPC parameter to connect and connectProvider methods
  • Initialize RPC field with null value in constructor
  • Import and utilize DEFAULT_RPC_URL as fallback option
  • Replace hardcoded RPC URL with configurable parameter

Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix.
Please check out some of the comments.

@tfrg tfrg force-pushed the feat/dynamic-rpc-config branch from 94c0099 to 6444fa2 Compare December 29, 2024 12:14
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jinoosss jinoosss merged commit 38684a6 into onbloc:main Dec 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants