feat: reorder arguments in tx link #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinoosss
requested review from
dongwon8247 and
onlyhyde
and removed request for
a team
Base automatically changed from
ADN-697-handle-account-mismatch-errors-in-tx-link-transactions
to
main
April 10, 2025 06:40
jinoosss
force-pushed
the
ADN-698-reorder-arguments-in-tx-link
branch
from
f5b3b37 to
dd962c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does:
based on gnolang/gno#4073,
Change the way messages are generated from Adena tx link.
Previously, Adena generated arguments based on the order of the parameters in tx link,
but now Adena set the parameters based on the function information defined in the
vm/qdoc.vm/qdocto set the order and number of arguments.