Skip to content

Conversation

@jinoosss
Copy link
Member

@jinoosss jinoosss commented May 23, 2025

What type of PR is this?

  • bug

What this PR does:

This PR improves the transfer functionality by properly handling the network fee loading state. It ensures that transfers cannot be initiated while the network fee is still being calculated.

Changes

  • Added network fee loading state check in transfer conditions
  • Removed redundant network fee error check

Technical Details

  • Added useNetworkFeeReturn.isLoading check to transfer conditions
  • Removed isNetworkFeeError check from regular transfer flow
  • Maintained consistent validation logic across transfer types

@jinoosss jinoosss requested a review from a team as a code owner May 23, 2025 06:42
@jinoosss jinoosss requested review from dongwon8247 and tfrg May 23, 2025 06:42
@jinoosss jinoosss merged commit ea5e580 into main May 23, 2025
2 checks passed
@jinoosss jinoosss deleted the ADN-716-fix-adjust-transfer-conditions branch May 23, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants